From e45313c031574814c392539e57993a02289ac6b3 Mon Sep 17 00:00:00 2001 From: =?utf8?q?J=C3=A1n=20Tomko?= Date: Wed, 6 Nov 2024 14:03:27 +0100 Subject: [PATCH] ch: check return value of virJSONValueArrayAppend MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit It only errors out when presented with a non-array, but we do check it everywhere else. Signed-off-by: Ján Tomko Reviewed-by: Peter Krempa --- src/ch/ch_monitor.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/ch/ch_monitor.c b/src/ch/ch_monitor.c index 3e49902791..ccd04cfbd1 100644 --- a/src/ch/ch_monitor.c +++ b/src/ch/ch_monitor.c @@ -1002,7 +1002,8 @@ virCHMonitorBuildRestoreJson(virDomainDef *vmdef, return -1; if (virJSONValueObjectAppendNumberInt(net_json, "num_fds", vmdef->nets[i]->driver.virtio.queues)) return -1; - virJSONValueArrayAppend(nets, &net_json); + if (virJSONValueArrayAppend(nets, &net_json) < 0) + return -1; } if (virJSONValueObjectAppend(restore_json, "net_fds", &nets)) return -1; -- 2.47.2