From e460f9215660822813e868de5859e51111e70201 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Vladim=C3=ADr=20=C4=8Cun=C3=A1t?= Date: Wed, 22 Apr 2020 13:38:39 +0200 Subject: [PATCH] iterate: use resolve_badmsg() fallback for more RCODEs + REFUSED and SERVFAIL (in non-STUB) --- lib/layer/iterate.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/lib/layer/iterate.c b/lib/layer/iterate.c index 55f79abb0..6558c50b7 100644 --- a/lib/layer/iterate.c +++ b/lib/layer/iterate.c @@ -1069,14 +1069,12 @@ static int resolve(kr_layer_t *ctx, knot_pkt_t *pkt) case KNOT_RCODE_NXDOMAIN: break; /* OK */ case KNOT_RCODE_REFUSED: - case KNOT_RCODE_SERVFAIL: { + case KNOT_RCODE_SERVFAIL: if (query->flags.STUB) { - /* Pass through in stub mode */ + /* just pass answer through if in stub mode */ break; } - VERBOSE_MSG("<= rcode: %s\n", rcode ? rcode->name : "??"); - return KR_STATE_FAIL; - } + /* fall through */ case KNOT_RCODE_FORMERR: VERBOSE_MSG("<= rcode: %s\n", rcode ? rcode->name : "??"); return resolve_badmsg(pkt, req, query); -- 2.47.2