From e4648736bea94c7893dafc80fc6ba6a96ae980a5 Mon Sep 17 00:00:00 2001 From: Jonathon Jongsma Date: Wed, 21 Oct 2020 16:50:06 -0500 Subject: [PATCH] qemu: fix potential resource leak Coverity reported a potential resource leak. While it's probably not a real-world scenario, the code could technically jump to cleanup between the time that vdpafd is opened and when it is used. Ensure that it gets cleaned up in that case. Signed-off-by: Jonathon Jongsma Reviewed-by: Laine Stump --- src/qemu/qemu_command.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index e10121cf94..7847706594 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -8145,6 +8145,7 @@ qemuBuildInterfaceCommandLine(virQEMUDriverPtr driver, addfdarg = g_strdup_printf("%s,opaque=%s", fdset, net->data.vdpa.devicepath); virCommandAddArgList(cmd, "-add-fd", addfdarg, NULL); + vdpafd = -1; } if (chardev) @@ -8214,6 +8215,7 @@ qemuBuildInterfaceCommandLine(virQEMUDriverPtr driver, VIR_FREE(tapfdName); VIR_FREE(vhostfd); VIR_FREE(tapfd); + VIR_FORCE_CLOSE(vdpafd); return ret; } -- 2.47.2