From e46883e27e7e032915df64e51a53648570a74e07 Mon Sep 17 00:00:00 2001 From: Riccardo Magliocchetti Date: Wed, 17 Jan 2018 17:30:36 -0500 Subject: [PATCH] Add a few more MySQL 8.0 reserved words Reference: https://dev.mysql.com/doc/refman/8.0/en/keywords.html Change-Id: I3f2f1827b659559cbee0f2b8aa3573ddfd551289 Pull-request: https://github.com/zzzeek/sqlalchemy/pull/414 --- doc/build/changelog/unreleased_12/mysql_res.rst | 6 ++++++ lib/sqlalchemy/dialects/mysql/base.py | 6 ++++-- 2 files changed, 10 insertions(+), 2 deletions(-) create mode 100644 doc/build/changelog/unreleased_12/mysql_res.rst diff --git a/doc/build/changelog/unreleased_12/mysql_res.rst b/doc/build/changelog/unreleased_12/mysql_res.rst new file mode 100644 index 0000000000..b6d72f9eba --- /dev/null +++ b/doc/build/changelog/unreleased_12/mysql_res.rst @@ -0,0 +1,6 @@ +.. change:: + :tags: bug, mysql + + Added more MySQL 8.0 reserved words to the MySQL dialect + for quoting purposes. Pull request courtesy + Riccardo Magliocchetti. diff --git a/lib/sqlalchemy/dialects/mysql/base.py b/lib/sqlalchemy/dialects/mysql/base.py index b0f0a89ae4..a304d04f68 100644 --- a/lib/sqlalchemy/dialects/mysql/base.py +++ b/lib/sqlalchemy/dialects/mysql/base.py @@ -768,8 +768,10 @@ RESERVED_WORDS = set( 'generated', 'optimizer_costs', 'stored', 'virtual', # 5.7 - 'admin', 'except', 'grouping', 'of', 'persist', 'recursive', - 'role', # 8.0 + 'admin', 'cume_dist', 'empty', 'except', 'first_value', 'grouping', + 'groups', 'json_table', 'last_value', 'nth_value', 'ntile', 'of', + 'over', 'percent_rank', 'persist', 'persist_only', 'rank', 'recursive', + 'role', 'row', 'rows', 'row_number', 'system', 'window', # 8.0 ]) -- 2.47.2