From e4cd7a7d0bf8b69a9fdbabaab5b9c4fa48e42cbb Mon Sep 17 00:00:00 2001 From: Sean Bright Date: Mon, 8 Mar 2021 15:06:00 -0500 Subject: [PATCH] strings.h: ast_str_to_upper() and _to_lower() are not pure. Because they modify their argument they are not pure functions and should not be marked as such, otherwise the compiler may optimize them away. ASTERISK-29306 #close Change-Id: Ibec03a08522dd39e8a137ece9bc6a3059dfaad5f --- include/asterisk/strings.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/asterisk/strings.h b/include/asterisk/strings.h index e9d786c2f3..929cbf5256 100644 --- a/include/asterisk/strings.h +++ b/include/asterisk/strings.h @@ -1265,7 +1265,7 @@ static force_inline int attribute_pure ast_str_case_hash(const char *str) * * \retval str for convenience */ -static force_inline char *attribute_pure ast_str_to_lower(char *str) +static force_inline char *ast_str_to_lower(char *str) { char *str_orig = str; if (!str) { @@ -1286,7 +1286,7 @@ static force_inline char *attribute_pure ast_str_to_lower(char *str) * * \retval str for convenience */ -static force_inline char *attribute_pure ast_str_to_upper(char *str) +static force_inline char *ast_str_to_upper(char *str) { char *str_orig = str; if (!str) { -- 2.47.2