From e4ef389e761bc37904f5cf64b99af5c6c603f2ba Mon Sep 17 00:00:00 2001 From: Steven Rostedt Date: Wed, 7 Jan 2026 16:15:10 -0500 Subject: [PATCH] tracing: Check the return value of tracing_update_buffers() In the very unlikely event that tracing_update_buffers() fails in trace_printk_init_buffers(), report the failure so that it is known. Link: https://lore.kernel.org/all/20220917020353.3836285-1-floridsleeves@gmail.com/ Cc: Mathieu Desnoyers Link: https://patch.msgid.link/20260107161510.4dc98b15@gandalf.local.home Suggested-by: Li Zhong Acked-by: Masami Hiramatsu (Google) Signed-off-by: Steven Rostedt (Google) --- kernel/trace/trace.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index 8bd4ec08fb361..870205cba31ef 100644 --- a/kernel/trace/trace.c +++ b/kernel/trace/trace.c @@ -3309,9 +3309,10 @@ void trace_printk_init_buffers(void) pr_warn("**********************************************************\n"); /* Expand the buffers to set size */ - tracing_update_buffers(&global_trace); - - buffers_allocated = 1; + if (tracing_update_buffers(&global_trace) < 0) + pr_err("Failed to expand tracing buffers for trace_printk() calls\n"); + else + buffers_allocated = 1; /* * trace_printk_init_buffers() can be called by modules. -- 2.47.3