From e52a729bd04fc7c596267db9bbd684286355f009 Mon Sep 17 00:00:00 2001 From: Walter Doekes Date: Fri, 11 Nov 2011 21:29:05 +0000 Subject: [PATCH] Fix bad quoting of multiline mxml opaque_data that caused invalid xml. The opaque_data was added and enclosed in single quotes, assuming it would be only a single line. The rest of the lines were appended after the closing quote. (closes issue ASTERISK-18852) Reported by: peep_ on IRC Review: https://reviewboard.asterisk.org/r/1577 ........ Merged revisions 344835 from http://svn.asterisk.org/svn/asterisk/branches/1.8 git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/10@344836 65c4cc65-6c06-0410-ace0-fbb531ad65f3 --- main/manager.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/main/manager.c b/main/manager.c index 56caa0561f..78147ce9a9 100644 --- a/main/manager.c +++ b/main/manager.c @@ -5745,9 +5745,10 @@ static void xml_translate(struct ast_str **out, char *in, struct ast_variable *g } if (in_data) { - /* Process data field in Opaque mode */ - xml_copy_escape(out, val, 0); /* data field */ + /* Process data field in Opaque mode. This is a + * followup, so we re-add line feeds. */ ast_str_append(out, 0, xml ? "\n" : "
\n"); + xml_copy_escape(out, val, 0); /* data field */ continue; } @@ -5783,7 +5784,9 @@ static void xml_translate(struct ast_str **out, char *in, struct ast_variable *g ao2_ref(vc, -1); ast_str_append(out, 0, xml ? "='" : ""); xml_copy_escape(out, val, 0); /* data field */ - ast_str_append(out, 0, xml ? "'" : "\n"); + if (!in_data || !*in) { + ast_str_append(out, 0, xml ? "'" : "\n"); + } } if (inobj) { -- 2.47.2