From e5dae2c6b0bcd0e4ac6e5b212688d223e2e62f79 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Fri, 27 Jul 2018 12:00:02 -0700 Subject: [PATCH] df: omit redundant comparison Trivial inefficiency reported by Bruno Haible in: http://lists.gnu.org/r/bug-gnulib/2018-07/msg00109.html * src/df.c (hide_problematic_chars): Omit redundant test. --- src/df.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/df.c b/src/df.c index 9b65872731..55532219f3 100644 --- a/src/df.c +++ b/src/df.c @@ -288,7 +288,7 @@ hide_problematic_chars (char *cell) wchar_t wc; size_t srcbytes = srcend - src; n = mbrtowc (&wc, src, srcbytes, &mbstate); - bool ok = 0 < n && n <= srcbytes; + bool ok = n <= srcbytes; if (ok) ok = !iswcntrl (wc); -- 2.47.2