From e8a396682be807d8c31ef58cd9d2a3020e0b37be Mon Sep 17 00:00:00 2001 From: Peter Krempa Date: Fri, 11 Jun 2021 10:08:37 +0200 Subject: [PATCH] bhyveConnectDomainXMLToNative: Fix memory leak in incorrect virCommandToString usage MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit virCommandToString returns an allocated buffer, so using it directly as argument of virBufferAdd which doesn't consume the string causes it to be leaked. Switch to virBufferToStringBuf since we are already using a buffer. Signed-off-by: Peter Krempa Reviewed-by: Ján Tomko --- src/bhyve/bhyve_driver.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/bhyve/bhyve_driver.c b/src/bhyve/bhyve_driver.c index 0fddf9533b..516490f6cd 100644 --- a/src/bhyve/bhyve_driver.c +++ b/src/bhyve/bhyve_driver.c @@ -723,14 +723,14 @@ bhyveConnectDomainXMLToNative(virConnectPtr conn, "", NULL))) goto cleanup; - virBufferAdd(&buf, virCommandToString(loadcmd, false), -1); + virCommandToStringBuf(loadcmd, &buf, false, false); virBufferAddChar(&buf, '\n'); } if (!(cmd = virBhyveProcessBuildBhyveCmd(privconn, def, true))) goto cleanup; - virBufferAdd(&buf, virCommandToString(cmd, false), -1); + virCommandToStringBuf(cmd, &buf, false, false); ret = virBufferContentAndReset(&buf); -- 2.47.2