From e94d0bd82761b7b41bc061368a11684f19130954 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Vincent=20Stehl=C3=A9?= Date: Tue, 3 Feb 2026 13:59:41 +0100 Subject: [PATCH] efi_loader: fix efi_debug_image_info_normal allocation MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit When adding a new EFI Debug Image Info entry, we allocate memory for a new EFI Debug Image Info Normal structure and we add a new entry into the EFI Debug Image Info Table, which is in fact just a pointer to the allocated structure. However, when allocating memory for the new structure we allocate memory for the wrong type, leading to allocating memory for just a pointer instead of the desired structure. Fix the type used during allocation. Fixes: 146546138af5 ("efi: add EFI_DEBUG_IMAGE_INFO for debug") Signed-off-by: Vincent Stehlé Cc: Heinrich Schuchardt Cc: Ilias Apalodimas Cc: Tom Rini Cc: Ying-Chun Liu (PaulLiu) Reviewed-by: Heinrich Schuchardt --- lib/efi_loader/efi_debug_support.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/efi_loader/efi_debug_support.c b/lib/efi_loader/efi_debug_support.c index 490b0bb7088..8d0c133871e 100644 --- a/lib/efi_loader/efi_debug_support.c +++ b/lib/efi_loader/efi_debug_support.c @@ -111,7 +111,7 @@ efi_status_t efi_core_new_debug_image_info_entry(u32 image_info_type, /* Allocate data for new entry. */ ret = efi_allocate_pool(EFI_BOOT_SERVICES_DATA, - sizeof(union efi_debug_image_info), + sizeof(struct efi_debug_image_info_normal), (void **)(&(*table)[index].normal_image)); if (ret == EFI_SUCCESS && (*table)[index].normal_image) { /* Update the entry. */ -- 2.47.3