From e95d362ba71845e84a45cc5b081620fb970d0f7b Mon Sep 17 00:00:00 2001 From: Pavel Hrdina Date: Thu, 6 Mar 2025 12:09:22 +0100 Subject: [PATCH] domain_conf: graphics: extract EGL-Headless formatting to separate function MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit virDomainGraphicsDefFormat function was way too long so split it into separate functions for each graphics type. Signed-off-by: Pavel Hrdina Reviewed-by: Ján Tomko --- src/conf/domain_conf.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 702bc13283..85db84c496 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -26602,6 +26602,14 @@ virDomainGraphicsDefFormatSpice(virBuffer *attrBuf, return 0; } +static void +virDomainGraphicsDefFormatEGLHeadless(virBuffer *childBuf, + virDomainGraphicsDef *def) +{ + virDomainGraphicsDefFormatGL(childBuf, VIR_TRISTATE_BOOL_ABSENT, + def->data.egl_headless.rendernode); +} + static int virDomainGraphicsDefFormat(virBuffer *buf, virDomainGraphicsDef *def, @@ -26644,9 +26652,9 @@ virDomainGraphicsDefFormat(virBuffer *buf, break; case VIR_DOMAIN_GRAPHICS_TYPE_EGL_HEADLESS: - virDomainGraphicsDefFormatGL(&childBuf, VIR_TRISTATE_BOOL_ABSENT, - def->data.egl_headless.rendernode); + virDomainGraphicsDefFormatEGLHeadless(&childBuf, def); break; + case VIR_DOMAIN_GRAPHICS_TYPE_DBUS: if (def->data.dbus.p2p) virBufferAddLit(&attrBuf, " p2p='yes'"); -- 2.47.3