From ea0a1076181f27af39a0653f08fbc705e2b784ce Mon Sep 17 00:00:00 2001 From: Masatake YAMATO Date: Thu, 3 Oct 2024 15:17:01 +0900 Subject: [PATCH] lsfd: avoid accessing an uninitialized value sb, a local variable in collect_file_symlink, accessed at bool is_socket = (sb.st_mode & S_IFMT) == S_IFSOCK; was not initialized if copy_file path is taken. Signed-off-by: Masatake YAMATO --- lsfd-cmd/lsfd.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lsfd-cmd/lsfd.c b/lsfd-cmd/lsfd.c index 6b93016d9..09ef9a588 100644 --- a/lsfd-cmd/lsfd.c +++ b/lsfd-cmd/lsfd.c @@ -849,9 +849,10 @@ static struct file *collect_file_symlink(struct path_cxt *pc, */ else if ((prev = list_last_entry(&proc->files, struct file, files)) && (!prev->is_error) - && prev->name && strcmp(prev->name, sym) == 0) + && prev->name && strcmp(prev->name, sym) == 0) { f = copy_file(prev, assoc); - else if (ul_path_stat(pc, &sb, 0, name) < 0) + sb = prev->stat; + } else if (ul_path_stat(pc, &sb, 0, name) < 0) f = new_stat_error_file(proc, sym, errno, assoc); else { const struct file_class *class = stat2class(&sb); -- 2.47.3