From ea61d53c0f8b70e39c2586229b4b42f6ada2c7e9 Mon Sep 17 00:00:00 2001 From: Zoran Date: Wed, 18 May 2016 22:18:07 -0700 Subject: [PATCH] rework gem namespacing - Foundation::Emails is now FoundationEmails; improve gemspec file inclusion, and create a scss partial to remove name redundancy when requiring framework's scss --- gem/README.md | 4 ++-- gem/foundation-emails.gemspec | 10 +++++----- gem/lib/foundation/emails.rb | 7 ------- gem/lib/foundation/emails/version.rb | 5 ----- gem/lib/foundation_emails.rb | 5 +++++ gem/lib/foundation_emails/engine.rb | 6 ++++++ gem/lib/foundation_emails/version.rb | 3 +++ gem/vendor/assets/stylesheets/_foundation-emails.scss | 1 + 8 files changed, 22 insertions(+), 19 deletions(-) delete mode 100644 gem/lib/foundation/emails.rb delete mode 100644 gem/lib/foundation/emails/version.rb create mode 100644 gem/lib/foundation_emails.rb create mode 100644 gem/lib/foundation_emails/engine.rb create mode 100644 gem/lib/foundation_emails/version.rb create mode 100644 gem/vendor/assets/stylesheets/_foundation-emails.scss diff --git a/gem/README.md b/gem/README.md index 7f8cfe56..50205f77 100644 --- a/gem/README.md +++ b/gem/README.md @@ -1,4 +1,4 @@ -# Foundation::Emails +# Foundation for Emails Gem Foundation for Emails (previously known as Ink) is a framework for creating responsive HTML emails that work in any email client — even Outlook. Our HTML/CSS components have been tested across every major email client to ensure consistency. @@ -7,7 +7,7 @@ Foundation for Emails (previously known as Ink) is a framework for creating resp Add this line to your application's Gemfile: ```ruby -gem 'foundation-emails' +gem 'foundation_emails' ``` Or install it yourself as: diff --git a/gem/foundation-emails.gemspec b/gem/foundation-emails.gemspec index a5e5ba2f..cfbaef80 100644 --- a/gem/foundation-emails.gemspec +++ b/gem/foundation-emails.gemspec @@ -1,11 +1,11 @@ # coding: utf-8 lib = File.expand_path("../lib", __FILE__) $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib) -require "foundation/emails/version" +require "foundation_emails/version" Gem::Specification.new do |spec| - spec.name = "foundation-emails" - spec.version = Foundation::Emails::VERSION + spec.name = "foundation_emails" + spec.version = FoundationEmails::VERSION spec.authors = ["ZURB"] spec.email = ["foundation@zurb.com"] @@ -14,8 +14,8 @@ Gem::Specification.new do |spec| spec.homepage = "http://foundation.zurb.com/emails" spec.license = "MIT" - spec.files = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features|vendor)/}) } - # Include symlinked files separately via Dir.glob + spec.files = Dir[ File.join("**", "*") ].reject { |p| File.directory?(p) || p.match(%{^(test|spec|features)/}) } + # Include symlinked files separately spec.files += Dir.glob("vendor/assets/stylesheets/foundation-emails/**/*.*") spec.bindir = "exe" spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) } diff --git a/gem/lib/foundation/emails.rb b/gem/lib/foundation/emails.rb deleted file mode 100644 index 5bd5f44c..00000000 --- a/gem/lib/foundation/emails.rb +++ /dev/null @@ -1,7 +0,0 @@ -require "foundation/emails/version" - -module Foundation - module Emails - # Your code goes here... - end -end diff --git a/gem/lib/foundation/emails/version.rb b/gem/lib/foundation/emails/version.rb deleted file mode 100644 index d112ce14..00000000 --- a/gem/lib/foundation/emails/version.rb +++ /dev/null @@ -1,5 +0,0 @@ -module Foundation - module Emails - VERSION = "0.1.0" - end -end diff --git a/gem/lib/foundation_emails.rb b/gem/lib/foundation_emails.rb new file mode 100644 index 00000000..7dae7744 --- /dev/null +++ b/gem/lib/foundation_emails.rb @@ -0,0 +1,5 @@ +require "foundation_emails/engine" + +module FoundationEmails + +end diff --git a/gem/lib/foundation_emails/engine.rb b/gem/lib/foundation_emails/engine.rb new file mode 100644 index 00000000..f762576e --- /dev/null +++ b/gem/lib/foundation_emails/engine.rb @@ -0,0 +1,6 @@ +require "rails" + +module FoundationEmails + class Engine < ::Rails::Engine + end +end diff --git a/gem/lib/foundation_emails/version.rb b/gem/lib/foundation_emails/version.rb new file mode 100644 index 00000000..06977434 --- /dev/null +++ b/gem/lib/foundation_emails/version.rb @@ -0,0 +1,3 @@ +module FoundationEmails + VERSION = "0.1.0" +end diff --git a/gem/vendor/assets/stylesheets/_foundation-emails.scss b/gem/vendor/assets/stylesheets/_foundation-emails.scss new file mode 100644 index 00000000..d53c47af --- /dev/null +++ b/gem/vendor/assets/stylesheets/_foundation-emails.scss @@ -0,0 +1 @@ +@import "foundation-emails/foundation-emails"; -- 2.47.2