From eb0d3fb9c10041590fbdcdfab6794d1991e7aed7 Mon Sep 17 00:00:00 2001
From: Harald Hoyer <harald@redhat.com>
Date: Fri, 26 Mar 2021 10:29:26 +0100
Subject: [PATCH] fix(fcoe-uefi): shellcheck for modules.d/95fcoe-uefi

---
 modules.d/95fcoe-uefi/.shchkdir         | 0
 modules.d/95fcoe-uefi/module-setup.sh   | 2 +-
 modules.d/95fcoe-uefi/parse-uefifcoe.sh | 4 ++--
 3 files changed, 3 insertions(+), 3 deletions(-)
 create mode 100644 modules.d/95fcoe-uefi/.shchkdir

diff --git a/modules.d/95fcoe-uefi/.shchkdir b/modules.d/95fcoe-uefi/.shchkdir
new file mode 100644
index 000000000..e69de29bb
diff --git a/modules.d/95fcoe-uefi/module-setup.sh b/modules.d/95fcoe-uefi/module-setup.sh
index 9e5719dfb..d1804cc6f 100755
--- a/modules.d/95fcoe-uefi/module-setup.sh
+++ b/modules.d/95fcoe-uefi/module-setup.sh
@@ -3,7 +3,7 @@
 # called by dracut
 check() {
     is_fcoe() {
-        block_is_fcoe $1 || return 1
+        block_is_fcoe "$1" || return 1
     }
 
     [[ $hostonly ]] || [[ $mount_needs ]] && {
diff --git a/modules.d/95fcoe-uefi/parse-uefifcoe.sh b/modules.d/95fcoe-uefi/parse-uefifcoe.sh
index 942d85dd2..e120dec32 100755
--- a/modules.d/95fcoe-uefi/parse-uefifcoe.sh
+++ b/modules.d/95fcoe-uefi/parse-uefifcoe.sh
@@ -8,7 +8,7 @@ print_fcoe_uefi_conf() {
     local mac dev vlan
     mac=$(get_fcoe_boot_mac "$1")
     [ -z "$mac" ] && return 1
-    dev=$(set_ifname fcoe $mac)
+    dev=$(set_ifname fcoe "$mac")
     vlan=$(get_fcoe_boot_vlan "$1")
     if [ "$vlan" -ne "0" ]; then
         case "$vlan" in
@@ -29,5 +29,5 @@ print_fcoe_uefi_conf() {
 
 for i in /sys/firmware/efi/efivars/FcoeBootDevice-*; do
     [ -e "$i" ] || continue
-    print_fcoe_uefi_conf $i > /etc/cmdline.d/40-fcoe-uefi.conf && break
+    print_fcoe_uefi_conf "$i" > /etc/cmdline.d/40-fcoe-uefi.conf && break
 done
-- 
2.47.3