From eb24e7cfd79ac09bf3a812c3fdf6617c89262bc1 Mon Sep 17 00:00:00 2001 From: Nicolas Coden Date: Thu, 29 Mar 2018 19:30:58 +0200 Subject: [PATCH] fix: move extend outside of mediaquery for sass compatibility Libsass 3.5 does not support using `@extend` inside the same mediaquery as the placeholder. `@extend` must be used outside of any mediequery. See https://github.com/zurb/foundation-sites/pull/11094 --- scss/components/_reveal.scss | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/scss/components/_reveal.scss b/scss/components/_reveal.scss index 78f2d71e4..2f91f2265 100644 --- a/scss/components/_reveal.scss +++ b/scss/components/_reveal.scss @@ -41,6 +41,7 @@ $reveal-overlay-background: rgba($black, 0.45) !default; // Placeholder selector for medium-and-up modals // Prevents duplicate CSS when defining multiple Reveal sizes +// This should be in the same breakpoint then `@mixin reveal-modal-width` @include breakpoint(medium) { %reveal-centered { right: auto; @@ -101,8 +102,9 @@ $reveal-overlay-background: rgba($black, 0.45) !default; $width: $reveal-width, $max-width: $reveal-max-width ) { + // Extends must be made outside of breakpoints for compatibility with newer Sass versions (libsass v3.5) + @extend %reveal-centered; @include breakpoint(medium) { - @extend %reveal-centered; width: $width; max-width: $max-width; } -- 2.47.2