From ecda00059b14b95a5b84f3efc1c1f341e1fd7dbc Mon Sep 17 00:00:00 2001 From: Alex Hung Date: Fri, 26 Apr 2024 10:02:55 -0600 Subject: [PATCH] drm/amd/display: Skip plane when not found by stream id [Why & How] dml_stream_idx will be -1 when it is not found. Check and skip in such a case as -1 is not a valid array index. This fixes a NEGATIVE_RETURNS issue reported by Coverity. Reviewed-by: Harry Wentland Acked-by: Tom Chung Signed-off-by: Alex Hung Tested-by: Daniel Wheeler Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/display/dc/dml2/dml21/dml21_utils.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dml2/dml21/dml21_utils.c b/drivers/gpu/drm/amd/display/dc/dml2/dml21/dml21_utils.c index aa0cc4bb2b474..8c9e95b25eb30 100644 --- a/drivers/gpu/drm/amd/display/dc/dml2/dml21/dml21_utils.c +++ b/drivers/gpu/drm/amd/display/dc/dml2/dml21/dml21_utils.c @@ -465,7 +465,10 @@ void dml21_build_fams2_programming(const struct dc *dc, } dml_stream_idx = dml21_helper_find_dml_pipe_idx_by_stream_id(dml_ctx, stream->stream_id); - ASSERT(dml_stream_idx >= 0); + if (dml_stream_idx < 0) { + ASSERT(dml_stream_idx >= 0); + continue; + } /* copy static state from PMO */ memcpy(static_state, -- 2.39.5