From edaf698ba28512dc920a098d8a888d0c74b80e10 Mon Sep 17 00:00:00 2001 From: Francis Dupont Date: Wed, 17 Oct 2018 21:22:33 +0200 Subject: [PATCH] [5-netconf-extend-syntax] Addressed comments --- src/bin/netconf/netconf_cfg_mgr.h | 2 ++ src/bin/netconf/tests/netconf_tests.sh.in | 8 +++++++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/src/bin/netconf/netconf_cfg_mgr.h b/src/bin/netconf/netconf_cfg_mgr.h index ba1906ae39..d1e40597cb 100644 --- a/src/bin/netconf/netconf_cfg_mgr.h +++ b/src/bin/netconf/netconf_cfg_mgr.h @@ -36,6 +36,8 @@ public: NetconfConfig(); /// @brief Returns pointer to configured global parameters. + /// + /// @todo revisit this at the toElement first use. isc::data::ConstElementPtr getConfiguredGlobals() const { return (isc::data::ConstElementPtr(configured_globals_)); } diff --git a/src/bin/netconf/tests/netconf_tests.sh.in b/src/bin/netconf/tests/netconf_tests.sh.in index 80adc88e78..50143d04a9 100644 --- a/src/bin/netconf/tests/netconf_tests.sh.in +++ b/src/bin/netconf/tests/netconf_tests.sh.in @@ -15,7 +15,13 @@ EXPECTED_VERSION="@PACKAGE_VERSION@" CONFIG="{ \"Netconf\": { - \"comment\": \"some configuration will be stored here eventually.\" + \"managed-servers\": + { + \"dhcp4\": + { + \"comment\": \"simply use defaults...\" + } + } }, \"Logging\": -- 2.47.2