From ee474849c85116ec36e387882447f737ac3fdefb Mon Sep 17 00:00:00 2001 From: Phil Sutter Date: Mon, 2 Oct 2017 13:46:36 +0200 Subject: [PATCH] tc: flower: No need to cache indev arg Since addattrstrz() will copy the provided string into the attribute payload, there is no need to cache the data. Signed-off-by: Phil Sutter --- tc/f_flower.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/tc/f_flower.c b/tc/f_flower.c index 934832e2b..99e62a382 100644 --- a/tc/f_flower.c +++ b/tc/f_flower.c @@ -629,11 +629,8 @@ static int flower_parse_opt(struct filter_util *qu, char *handle, } else if (matches(*argv, "skip_sw") == 0) { flags |= TCA_CLS_FLAGS_SKIP_SW; } else if (matches(*argv, "indev") == 0) { - char ifname[IFNAMSIZ] = {}; - NEXT_ARG(); - strncpy(ifname, *argv, sizeof(ifname) - 1); - addattrstrz(n, MAX_MSG, TCA_FLOWER_INDEV, ifname); + addattrstrz(n, MAX_MSG, TCA_FLOWER_INDEV, *argv); } else if (matches(*argv, "vlan_id") == 0) { __u16 vid; -- 2.47.2