From ee6512e0d8a1da08321e038ef9d7070e0d086798 Mon Sep 17 00:00:00 2001 From: Stephen Finucane Date: Sun, 4 Sep 2016 01:29:01 +0100 Subject: [PATCH] views: Avoid mutable default arguments Signed-off-by: Stephen Finucane --- patchwork/views/__init__.py | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/patchwork/views/__init__.py b/patchwork/views/__init__.py index ddddf634..15695d66 100644 --- a/patchwork/views/__init__.py +++ b/patchwork/views/__init__.py @@ -185,9 +185,12 @@ def set_bundle(request, project, action, data, patches, context): return [] -def generic_list(request, project, view, - view_args={}, filter_settings=[], patches=None, - editable_order=False): +def generic_list(request, project, view, view_args=None, filter_settings=None, + patches=None, editable_order=False): + + if not filter_settings: + filter_settings = [] + filters = Filters(request) context = { 'project': project, @@ -220,7 +223,7 @@ def generic_list(request, project, view, 'order': order, 'list_view': { 'view': view, - 'view_params': view_args, + 'view_params': view_args or {}, 'params': params }}) -- 2.47.3