From ef4719ac17081e5e5fda6932334bb10f76b01ace Mon Sep 17 00:00:00 2001 From: Michal Privoznik Date: Mon, 30 Mar 2020 10:56:08 +0200 Subject: [PATCH] virQEMUCapsNewBinary: Avoid NULL dereference MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Even with GLib it is still possible for virQEMUCapsNew() to return NULL because it calls virQEMUCapsInitialize() which is a wrapper over pthread_once() which may fail. At least, we still check for its retval. If it so happens that the virQEMUCapsNew() fails and returns NULL, we should not dereference it. Signed-off-by: Michal Privoznik Reviewed-by: Daniel P. Berrangé --- src/qemu/qemu_capabilities.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index a95a60c36a..3afe8a7b2c 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -1713,7 +1713,8 @@ virQEMUCapsNewBinary(const char *binary) { virQEMUCapsPtr qemuCaps = virQEMUCapsNew(); - qemuCaps->binary = g_strdup(binary); + if (qemuCaps) + qemuCaps->binary = g_strdup(binary); return qemuCaps; } -- 2.47.2