From f06eb52fff1a4794edf26106d727c44ce3edfe22 Mon Sep 17 00:00:00 2001 From: Eric Blake Date: Fri, 30 Aug 2013 15:03:52 -0600 Subject: [PATCH] build: fix 'make distcheck' out of the box With the 1.1.1 tarball, if a user does 'make && make distcheck', things pass, but if they do 'make distcheck' after 'make clean', there is an odd failure: GEN ../../docs/devhelp/index.html I/O error : Permission denied I/O error : Permission denied runtime error: file ../../docs/devhelp/devhelp.xsl line 43 element document xsltDocumentElem: unable to save to ../../docs/devhelp/libvirt-virterror.html I/O error : Permission denied I/O error : Permission denied This implies that the rules for 'make dist' are missing a dependency - the generated documentation needs to be up-to-date before creating the tarball, or else the tarball will be missing files, where the end user will end up trying to rebuild files in srcdir, and that fails when srcdir is read-only. 1.1.1 plus this patch now works without issues (other issues have crept in to 1.1.2-rc1 that prevent 'make distcheck' from working, but those will be cleaned up in later patches). * docs/Makefile.am (dist-local): New dependency. Signed-off-by: Eric Blake --- docs/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/Makefile.am b/docs/Makefile.am index 0b0d2d454c..9939cc81be 100644 --- a/docs/Makefile.am +++ b/docs/Makefile.am @@ -288,6 +288,7 @@ $(APIBUILD_STAMP): $(srcdir)/apibuild.py \ check-local: all +dist-local: all clean-local: rm -f *~ *.bak *.hierarchy *.signals *-unused.txt *.html -- 2.47.2