From f07f5b008f180a8b44f8007f7ef8fb7ba47fd7ce Mon Sep 17 00:00:00 2001 From: Samuel Tardieu Date: Fri, 5 Jan 2024 16:51:34 +0100 Subject: [PATCH] maint: add attributes to two functions without side effects * src/date.c (res_width): This function computes its result solely from the value of its parameter and qualifies for the const attribute. * src/tee.c (get_next_out): This function has no side effect and qualifies for the pure attribute. * THANKS.in: Remove duplicate now that author has a commit in the repo. Those two functions were flagged by GCC 12.3.0, though not by GCC 13.2.1. --- THANKS.in | 1 - src/date.c | 1 + src/tee.c | 1 + 3 files changed, 2 insertions(+), 1 deletion(-) diff --git a/THANKS.in b/THANKS.in index 83bee6a7ec..47144a5ceb 100644 --- a/THANKS.in +++ b/THANKS.in @@ -566,7 +566,6 @@ Rudolf Kastl rkastl@redhat.com Sahil Amoli sahilamoli@gmail.com Sami Farin sfarin@ratol.fi Samuel Neves sneves@dei.uc.pt -Samuel Tardieu sam@rfc1149.net Samuel Thibault samuel.thibault@ens-lyon.org Samuli Karkkainen Samuli.Karkkainen@hut.fi Sander van Malssen svm@kozmix.ow.nl diff --git a/src/date.c b/src/date.c index 39fc0715df..03bf012e2c 100644 --- a/src/date.c +++ b/src/date.c @@ -294,6 +294,7 @@ Show the local time for 9AM next Friday on the west coast of the US\n\ /* Yield the number of decimal digits needed to output a time with the nanosecond resolution RES, without losing information. */ +ATTRIBUTE_CONST static int res_width (long int res) { diff --git a/src/tee.c b/src/tee.c index 07d525c95a..eb074427cb 100644 --- a/src/tee.c +++ b/src/tee.c @@ -185,6 +185,7 @@ main (int argc, char **argv) /* Return the index of the first non-null descriptor after idx, or -1 if all are null. */ +ATTRIBUTE_PURE static int get_next_out (FILE **descriptors, int nfiles, int idx) { -- 2.47.2