From f2bd39091a2c59cf3b47aa840b191af4812fc907 Mon Sep 17 00:00:00 2001 From: Kamalesh Babulal Date: Sun, 17 Sep 2023 10:22:56 +0530 Subject: [PATCH] gunit/009: fix string truncation warnings MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Fix string truncation warnings across the test case: 009-cgroup_set_values_recursive.cpp: In member function ‘virtual void SetValuesRecursiveTest_SuccessfulSetValues_Test::TestBody()’: 009-cgroup_set_values_recursive.cpp:96:10: warning: ‘char* strncpy(char*, const char*, size_t)’ specified bound 4096 equals destination size [-Wstringop-truncation] strncpy(ctrlr.values[i]->name, NAMES[i], FILENAME_MAX); ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 009-cgroup_set_values_recursive.cpp:97:10: warning: ‘char* strncpy(char*, const char*, size_t)’ specified bound 4096 equals destination size [-Wstringop-truncation] strncpy(ctrlr.values[i]->value, VALUES[i], ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ CG_CONTROL_VALUE_MAX); ~~~~~~~~~~~~~~~~~~~~~ Signed-off-by: Kamalesh Babulal Signed-off-by: Tom Hromatka --- tests/gunit/009-cgroup_set_values_recursive.cpp | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tests/gunit/009-cgroup_set_values_recursive.cpp b/tests/gunit/009-cgroup_set_values_recursive.cpp index 0e7b09d8..933da95c 100644 --- a/tests/gunit/009-cgroup_set_values_recursive.cpp +++ b/tests/gunit/009-cgroup_set_values_recursive.cpp @@ -93,9 +93,13 @@ TEST_F(SetValuesRecursiveTest, SuccessfulSetValues) sizeof(struct control_value)); ASSERT_NE(ctrlr.values[i], nullptr); - strncpy(ctrlr.values[i]->name, NAMES[i], FILENAME_MAX); + strncpy(ctrlr.values[i]->name, NAMES[i], FILENAME_MAX - 1); + ctrlr.values[i]->name[FILENAME_MAX - 1] = '\0'; + strncpy(ctrlr.values[i]->value, VALUES[i], - CG_CONTROL_VALUE_MAX); + CG_CONTROL_VALUE_MAX - 1); + ctrlr.values[i]->value[CG_CONTROL_VALUE_MAX - 1] = '\0'; + if (i == 0) ctrlr.values[i]->dirty = true; else -- 2.47.2