From f3f21d21f7ac47a2f74eb0bbc109ae6019723ae7 Mon Sep 17 00:00:00 2001 From: Kamalesh Babulal Date: Wed, 19 Jul 2023 12:35:50 +0530 Subject: [PATCH] tools/cgsnapshot: fix string null terminate in parse_controllers() Fix string not null terminated warning, reported by the Coverity tool: CID 258299 (#2 of 2): String not null terminated (STRING_NULL)18. string_null: Passing unterminated string *controllers to display_controller_data, which expects a null-terminated string. use snprintf() instead of strncpy() and manually terminate the string to keep Coverity happy. Signed-off-by: Kamalesh Babulal Signed-off-by: Tom Hromatka --- src/tools/cgsnapshot.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/tools/cgsnapshot.c b/src/tools/cgsnapshot.c index 9917e134..ff5cc108 100644 --- a/src/tools/cgsnapshot.c +++ b/src/tools/cgsnapshot.c @@ -529,8 +529,7 @@ static int is_ctlr_on_list(char controllers[CG_CONTROLLER_MAX][FILENAME_MAX], /* Lets reset the controllers to intersection of controller ∩ wanted_conts */ for (i = 0; tmp_controllers[i][0] != '\0'; i++) { - strncpy(controllers[i], tmp_controllers[i], FILENAME_MAX - 1); - (controllers[i])[FILENAME_MAX - 1] = '\0'; + snprintf(controllers[i], FILENAME_MAX, "%s", tmp_controllers[i]); ret = 1; } (controllers[i])[0] = '\0'; -- 2.47.2