From f4829df9aeb54d246ee9a816921a78e268ba7701 Mon Sep 17 00:00:00 2001 From: Erik Skultety Date: Thu, 11 May 2017 15:26:47 +0200 Subject: [PATCH] qemu: Provide a much clearer message on device hot-plug Adjust the current message to make it clear, that it is the hotplug operation that is unsupported with the given host device type. https://bugzilla.redhat.com/show_bug.cgi?id=1450072 Signed-off-by: Erik Skultety --- src/qemu/qemu_hotplug.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 4ca10863c0..e8d29186eb 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -2674,7 +2674,7 @@ qemuDomainAttachHostDevice(virConnectPtr conn, { if (hostdev->mode != VIR_DOMAIN_HOSTDEV_MODE_SUBSYS) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("hostdev mode '%s' not supported"), + _("hotplug is not supported for hostdev mode '%s'"), virDomainHostdevModeTypeToString(hostdev->mode)); return -1; } @@ -2705,7 +2705,7 @@ qemuDomainAttachHostDevice(virConnectPtr conn, default: virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("hostdev subsys type '%s' not supported"), + _("hotplug is not supported for hostdev subsys type '%s'"), virDomainHostdevSubsysTypeToString(hostdev->source.subsys.type)); goto error; } @@ -4820,7 +4820,7 @@ qemuDomainDetachThisHostDevice(virQEMUDriverPtr driver, break; default: virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("hostdev subsys type '%s' not supported"), + _("hot unplug is not supported for hostdev subsys type '%s'"), virDomainHostdevSubsysTypeToString(detach->source.subsys.type)); return -1; } @@ -4852,7 +4852,7 @@ int qemuDomainDetachHostDevice(virQEMUDriverPtr driver, if (hostdev->mode != VIR_DOMAIN_HOSTDEV_MODE_SUBSYS) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("hostdev mode '%s' not supported"), + _("hot unplug is not supported for hostdev mode '%s'"), virDomainHostdevModeTypeToString(hostdev->mode)); return -1; } -- 2.47.2