From f603b99ad9becae453c2e9056a8bf1e082c7f68b Mon Sep 17 00:00:00 2001 From: Michal Privoznik Date: Mon, 8 Jun 2020 10:49:36 +0200 Subject: [PATCH] virSysinfoReadDMI: Drop needless virFindFileInPath() MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit When trying to decode DMI table, just before constructing virCommand() the decoder is looked for in PATH using virFindFileInPath(). Well, this is not necessary because virCommandRun() will do this too (in virExec()). Signed-off-by: Michal Privoznik Reviewed-by: Daniel P. Berrangé --- src/util/virsysinfo.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/src/util/virsysinfo.c b/src/util/virsysinfo.c index 296a2e2cc1..0f1210ab37 100644 --- a/src/util/virsysinfo.c +++ b/src/util/virsysinfo.c @@ -1119,20 +1119,12 @@ virSysinfoParseX86Memory(const char *base, virSysinfoDefPtr ret) virSysinfoDefPtr virSysinfoReadDMI(void) { - g_autofree char *path = NULL; g_auto(virSysinfoDefPtr) ret = NULL; g_autofree char *outbuf = NULL; g_autoptr(virCommand) cmd = NULL; - path = virFindFileInPath(SYSINFO_SMBIOS_DECODER); - if (path == NULL) { - virReportError(VIR_ERR_INTERNAL_ERROR, - _("Failed to find path for %s binary"), - SYSINFO_SMBIOS_DECODER); - return NULL; - } - - cmd = virCommandNewArgList(path, "-q", "-t", "0,1,2,3,4,17", NULL); + cmd = virCommandNewArgList(SYSINFO_SMBIOS_DECODER, + "-q", "-t", "0,1,2,3,4,17", NULL); virCommandSetOutputBuffer(cmd, &outbuf); if (virCommandRun(cmd, NULL) < 0) return NULL; -- 2.47.2