From f636d9216146fe11de754bf78207352507fb3b91 Mon Sep 17 00:00:00 2001 From: Miquel Raynal Date: Fri, 9 Jan 2026 18:18:23 +0100 Subject: [PATCH] mtd: spinand: Warn if using SSDR-only vendor commands in a non SSDR mode Both Macronix and Winbond have chip specific operations which are SSDR only. Trying to use them in an ODTR setup will fail and doing this is a pure software bug. Warn explicitly in this case. Signed-off-by: Miquel Raynal --- drivers/mtd/nand/spi/macronix.c | 2 ++ drivers/mtd/nand/spi/winbond.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/drivers/mtd/nand/spi/macronix.c b/drivers/mtd/nand/spi/macronix.c index 6b7cbcc6e2872..84be5e0402b5d 100644 --- a/drivers/mtd/nand/spi/macronix.c +++ b/drivers/mtd/nand/spi/macronix.c @@ -53,6 +53,8 @@ static SPINAND_OP_VARIANTS(macronix_ops, static struct spi_mem_op spinand_fill_macronix_read_eccsr_op(struct spinand_device *spinand, void *valptr) { + WARN_ON_ONCE(spinand->bus_iface != SSDR); + return (struct spi_mem_op)SPINAND_MACRONIX_READ_ECCSR_1S_0_1S(valptr); } diff --git a/drivers/mtd/nand/spi/winbond.c b/drivers/mtd/nand/spi/winbond.c index 419f4303a0dc7..90e4ece00cf5e 100644 --- a/drivers/mtd/nand/spi/winbond.c +++ b/drivers/mtd/nand/spi/winbond.c @@ -114,6 +114,8 @@ static SPINAND_OP_VARIANTS(winbond_w25_ops, static struct spi_mem_op spinand_fill_winbond_select_target_op(struct spinand_device *spinand, void *valptr) { + WARN_ON_ONCE(spinand->bus_iface != SSDR); + return (struct spi_mem_op)SPINAND_WINBOND_SELECT_TARGET_1S_0_1S(valptr); } -- 2.47.3