From f653d5eb169e3d0371eae388aecb0db0cb0b8c11 Mon Sep 17 00:00:00 2001 From: Mike Bayer Date: Sun, 23 Jan 2022 09:28:22 -0500 Subject: [PATCH] dont test squelched warnings against the filter I spent days on Ibcf09af25228d39ee5a943fda82d8a9302433726 reading it over and over again and noticed this slight inaccuracy 10 seconds after I merged it. the assert_warns_message() and assert_warns() functions should not consider a mismatched warning class as valid for a match. Change-Id: Ib8944dd95bcec1a7e4963917a5f4829e2ba27732 --- lib/sqlalchemy/testing/assertions.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/sqlalchemy/testing/assertions.py b/lib/sqlalchemy/testing/assertions.py index 2a00f1c140..5c79422dd1 100644 --- a/lib/sqlalchemy/testing/assertions.py +++ b/lib/sqlalchemy/testing/assertions.py @@ -187,6 +187,8 @@ def _expect_warnings( if not exception or not issubclass(exception, _EXC_CLS): if not squelch_other_warnings: return real_warn(msg, *arg, **kw) + else: + return if not filters and not raise_on_any_unexpected: return -- 2.47.2