From f6ddf4e7d40915c66834a035b29c33b6a7aa4b9f Mon Sep 17 00:00:00 2001 From: BJ Weschke Date: Thu, 28 Sep 2006 15:18:05 +0000 Subject: [PATCH] Fix race condion crash with get_member_status (#7864 - tim_ringenbach reported and patched) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43871 65c4cc65-6c06-0410-ace0-fbb531ad65f3 --- apps/app_queue.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/apps/app_queue.c b/apps/app_queue.c index a10b2ad081..5d46a8df10 100644 --- a/apps/app_queue.c +++ b/apps/app_queue.c @@ -432,11 +432,12 @@ enum queue_member_status { QUEUE_NORMAL }; -static enum queue_member_status get_member_status(const struct call_queue *q) +static enum queue_member_status get_member_status(struct call_queue *q) { struct member *member; enum queue_member_status result = QUEUE_NO_MEMBERS; + ast_mutex_lock(&q->lock); for (member = q->members; member; member = member->next) { if (member->paused) continue; @@ -448,10 +449,12 @@ static enum queue_member_status get_member_status(const struct call_queue *q) result = QUEUE_NO_REACHABLE_MEMBERS; break; default: + ast_mutex_unlock(&q->lock); return QUEUE_NORMAL; } } + ast_mutex_unlock(&q->lock); return result; } -- 2.47.2