From f75aa2857f7fedb9650cf7bf0738b8225f262e30 Mon Sep 17 00:00:00 2001 From: Daniel Stenberg Date: Wed, 5 Jun 2024 08:31:11 +0200 Subject: [PATCH] cfilters: make Curl_conn_connect always assign 'done' It could return error without assigning it, and we have a caller in multi.c that assumes it gets set. Spotted by CodeSonar Closes #13884 --- lib/cfilters.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/cfilters.c b/lib/cfilters.c index a1e405bc5e..60767aa389 100644 --- a/lib/cfilters.c +++ b/lib/cfilters.c @@ -345,8 +345,10 @@ CURLcode Curl_conn_connect(struct Curl_easy *data, cf = data->conn->cfilter[sockindex]; DEBUGASSERT(cf); - if(!cf) + if(!cf) { + *done = FALSE; return CURLE_FAILED_INIT; + } *done = cf->connected; if(!*done) { -- 2.47.3