From f7b80136a3df4396b19ebb86d4814d8cefe6d6db Mon Sep 17 00:00:00 2001 From: Tomas Mraz Date: Tue, 3 Oct 2023 14:43:13 +0200 Subject: [PATCH] DH_check: Emphasize the importance of return value check Reviewed-by: Matt Caswell Reviewed-by: Tom Cosgrove Reviewed-by: Paul Dale (Merged from https://github.com/openssl/openssl/pull/22262) --- doc/man3/DH_generate_parameters.pod | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/doc/man3/DH_generate_parameters.pod b/doc/man3/DH_generate_parameters.pod index bbcfe24ae6b..e677885597a 100644 --- a/doc/man3/DH_generate_parameters.pod +++ b/doc/man3/DH_generate_parameters.pod @@ -128,6 +128,10 @@ The parameter B is invalid. =back +If 0 is returned or B<*codes> is set to a nonzero value the supplied +parameters should not be used for Diffie-Hellman operations otherwise +the security properties of the key exchange are not guaranteed. + DH_check_ex(), DH_check_params() and DH_check_pub_key_ex() are similar to DH_check() and DH_check_params() respectively, but the error reasons are added to the thread's error queue instead of provided as return values from the -- 2.47.2