From f802a11d3ba808baba6cb2d31d706952df1e3159 Mon Sep 17 00:00:00 2001 From: Martin Schwenke Date: Thu, 4 Aug 2016 15:58:50 +1000 Subject: [PATCH] ctdb-tests: Fix CID 1361816 Buffer not null terminated (BUFFER_SIZE_WARNING) BUG: https://bugzilla.samba.org/show_bug.cgi?id=12110 Signed-off-by: Martin Schwenke Reviewed-by: Amitay Isaacs --- ctdb/tests/src/fake_ctdbd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ctdb/tests/src/fake_ctdbd.c b/ctdb/tests/src/fake_ctdbd.c index 35bca88b286..c27af4a4d7a 100644 --- a/ctdb/tests/src/fake_ctdbd.c +++ b/ctdb/tests/src/fake_ctdbd.c @@ -2196,8 +2196,8 @@ static void control_get_ifaces(TALLOC_CTX *mem_ctx, .link_state = iface->link_up, .references = iface->references, }; - strncpy(iface_list->iface[i].name, iface->name, - CTDB_IFACE_SIZE+2); + strlcpy(iface_list->iface[i].name, iface->name, + sizeof(iface_list->iface[i].name)); } reply.rdata.data.iface_list = iface_list; -- 2.47.2