From f836256e20de1ede8d8fbb85e331278b8eb78eb1 Mon Sep 17 00:00:00 2001 From: Victor Julien Date: Wed, 30 Mar 2016 09:39:46 +0200 Subject: [PATCH] detect: fix small mem leak on duplicate sigs Direct leak of 80 byte(s) in 5 object(s) allocated from: #0 0x4c673b in __interceptor_malloc (/home/victor/dev/suricata/src/suricata+0x4c673b) #1 0xb7a425 in DetectEngineSignatureIsDuplicate /home/victor/dev/suricata/src/detect-parse.c:1715:10 #2 0xb79390 in DetectEngineAppendSig /home/victor/dev/suricata/src/detect-parse.c:1836:19 #3 0x86fe56 in DetectLoadSigFile /home/victor/dev/suricata/src/detect.c:357:15 #4 0x815fee in ProcessSigFiles /home/victor/dev/suricata/src/detect.c:419:13 #5 0x8139a8 in SigLoadSignatures /home/victor/dev/suricata/src/detect.c:499:15 #6 0xfe435d in LoadSignatures /home/victor/dev/suricata/src/suricata.c:1979:9 #7 0xfcd87e in main /home/victor/dev/suricata/src/suricata.c:2345:17 #8 0x7fb66bf7cec4 in __libc_start_main /build/eglibc-3GlaMS/eglibc-2.19/csu/libc-start.c:287 --- src/detect-parse.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/detect-parse.c b/src/detect-parse.c index f451c5c87e..54035d2e09 100644 --- a/src/detect-parse.c +++ b/src/detect-parse.c @@ -1749,6 +1749,8 @@ static inline int DetectEngineSignatureIsDuplicate(DetectEngineCtx *de_ctx, * and discard the other one */ if (sw->s->rev <= sw_dup->s->rev) { ret = 1; + SCFree(sw); + sw = NULL; goto end; } -- 2.47.2