From f8717d2a723cf594617c3acb7e90992c881a3280 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Zbigniew=20J=C4=99drzejewski-Szmek?= Date: Mon, 12 Dec 2022 14:11:46 +0100 Subject: [PATCH] udevadm: emit deprecation notice in udevadm hwdb This tool was "deprecated" back in 65eb4378c3e1de25383d8cd606909e64c71edc80, but only by removing documentation. This is somewhat surprising, but udevadm hwdb --update and systemd-hwdb update generate different databases. udevadm runs in compat mode and (as far as I have been able to figure out from a quick look), it omits filename information and does some other changes to the datastructures. The consuming code (udev) is the same in both cases, so this "compatibility mode" seems very strange. But I don't think it's worth trying to figure out why things were done this way. Let's just push people towards the new code. Inspired by https://github.com/systemd/systemd/issues/25698#issuecomment-1346298094. --- src/udev/udevadm-hwdb.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/udev/udevadm-hwdb.c b/src/udev/udevadm-hwdb.c index a4468cf24f0..2f5429fd89d 100644 --- a/src/udev/udevadm-hwdb.c +++ b/src/udev/udevadm-hwdb.c @@ -87,6 +87,8 @@ int hwdb_main(int argc, char *argv[], void *userdata) { return log_error_errno(SYNTHETIC_ERRNO(EINVAL), "Either --update or --test must be used."); + log_notice("udevadm hwdb is deprecated. Use systemd-hwdb instead."); + if (arg_update) { r = hwdb_update(arg_root, arg_hwdb_bin_dir, arg_strict, true); if (r < 0) -- 2.47.3