From fa44bc8fd074d00d5cc7fe16f31da40487ee2804 Mon Sep 17 00:00:00 2001 From: Martin Kletzander Date: Fri, 10 Jul 2020 15:13:56 +0200 Subject: [PATCH] resctrl: Use exclusive lock for /sys/fs/resctrl MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit That's the way it should've been all the time. It was originally the case, but then the rework to virFileFlock() made the function ambiguous when it was created in commit 5a0a5f7fb5f5, and due to that it was misused in commit 657ddeff2313 and since then the lock being taken was shared rather than exclusive. Signed-off-by: Martin Kletzander Reviewed-by: Andrea Bolognani Reviewed-by: Ján Tomko --- src/util/virresctrl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virresctrl.c b/src/util/virresctrl.c index 3563fc560d..9b78a6cb15 100644 --- a/src/util/virresctrl.c +++ b/src/util/virresctrl.c @@ -463,7 +463,7 @@ virResctrlLockWrite(void) return -1; } - if (virFileFlock(fd, true, true) < 0) { + if (virFileFlock(fd, true, false) < 0) { virReportSystemError(errno, "%s", _("Cannot lock resctrl")); VIR_FORCE_CLOSE(fd); return -1; -- 2.47.2