From fa9e6a50da49bcab1da7533c72cee0687b4bb048 Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Wed, 25 Jul 2018 12:05:58 +0200 Subject: [PATCH] idmap: Make pointer initialization explicit Took me a few seconds to find this NULL initializer Signed-off-by: Volker Lendecke Reviewed-by: Jeremy Allison --- source3/winbindd/idmap_tdb_common.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/source3/winbindd/idmap_tdb_common.c b/source3/winbindd/idmap_tdb_common.c index 48d87bb16cf..ceb663c0ddd 100644 --- a/source3/winbindd/idmap_tdb_common.c +++ b/source3/winbindd/idmap_tdb_common.c @@ -221,14 +221,13 @@ NTSTATUS idmap_tdb_common_set_mapping(struct idmap_domain * dom, struct idmap_tdb_common_context *ctx; struct idmap_tdb_common_set_mapping_context state; NTSTATUS ret; - char *ksidstr, *kidstr; + char *ksidstr = NULL; + char *kidstr = NULL; if (!map || !map->sid) { return NT_STATUS_INVALID_PARAMETER; } - ksidstr = kidstr = NULL; - /* TODO: should we filter a set_mapping using low/high filters ? */ ctx = -- 2.47.3