From fabd1992465e6e179d9d8972915551a40299fcd3 Mon Sep 17 00:00:00 2001
From: Mike Bayer <mike_mp@zzzcomputing.com>
Date: Mon, 3 Jun 2013 18:11:32 -0400
Subject: [PATCH] - clean up some of the requires for cross-schema reflection -
 add oracle profile counts

---
 test/engine/test_reflection.py | 11 ++++-------
 test/requirements.py           |  7 +++++++
 2 files changed, 11 insertions(+), 7 deletions(-)

diff --git a/test/engine/test_reflection.py b/test/engine/test_reflection.py
index 066dbf0b3e..c490efff2c 100644
--- a/test/engine/test_reflection.py
+++ b/test/engine/test_reflection.py
@@ -1144,15 +1144,13 @@ class UnicodeReflectionTest(fixtures.TestBase):
 class SchemaTest(fixtures.TestBase):
 
     @testing.requires.schemas
-    @testing.fails_on_everything_except("postgresql", "unimplemented feature")
+    @testing.requires.cross_schema_fk_reflection
     def test_has_schema(self):
         eq_(testing.db.dialect.has_schema(testing.db, 'test_schema'), True)
         eq_(testing.db.dialect.has_schema(testing.db, 'sa_fake_schema_123'), False)
 
-    @testing.crashes('firebird', 'No schema support')
+    @testing.requires.schemas
     @testing.fails_on('sqlite', 'FIXME: unknown')
-    # fixme: revisit these below.
-    @testing.fails_on('access', 'FIXME: unknown')
     @testing.fails_on('sybase', 'FIXME: unknown')
     def test_explicit_default_schema(self):
         engine = testing.db
@@ -1191,9 +1189,7 @@ class SchemaTest(fixtures.TestBase):
         finally:
             metadata.drop_all()
 
-    @testing.crashes('firebird', 'No schema support')
-    # fixme: revisit these below.
-    @testing.fails_on('access', 'FIXME: unknown')
+    @testing.requires.schemas
     @testing.fails_on('sybase', 'FIXME: unknown')
     def test_explicit_default_schema_metadata(self):
         engine = testing.db
@@ -1244,6 +1240,7 @@ class SchemaTest(fixtures.TestBase):
         )
 
     @testing.requires.schemas
+    @testing.requires.cross_schema_fk_reflection
     @testing.provide_metadata
     def test_reflect_all_schemas_default_overlap(self):
         t1 = Table('t', self.metadata,
diff --git a/test/requirements.py b/test/requirements.py
index 807f21baca..fd3678eb52 100644
--- a/test/requirements.py
+++ b/test/requirements.py
@@ -240,6 +240,13 @@ class DefaultRequirements(SuiteRequirements):
                     "firebird"
                 ], "no schema support")
 
+    @property
+    def cross_schema_fk_reflection(self):
+        """target system must support reflection of inter-schema foreign keys
+        """
+        return only_on([
+                    "postgresql"
+                ])
 
     @property
     def update_nowait(self):
-- 
2.47.2