From fb6fb6d8d89d3f8ce3e87363bb89e5c9ffe07975 Mon Sep 17 00:00:00 2001 From: Stephan Bosch Date: Sun, 5 Oct 2025 00:24:00 +0200 Subject: [PATCH] auth: mech-cram-md5 - Refactor mech_cram_md5_auth_continue() --- src/auth/mech-cram-md5.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/src/auth/mech-cram-md5.c b/src/auth/mech-cram-md5.c index 6f8b419866..02cbf205b8 100644 --- a/src/auth/mech-cram-md5.c +++ b/src/auth/mech-cram-md5.c @@ -139,20 +139,20 @@ mech_cram_md5_auth_continue(struct auth_request *auth_request, auth_request); const char *error; - if (parse_cram_response(request, data, data_size, &error)) { - if (auth_request_set_username(auth_request, request->username, - &error)) { - auth_request_lookup_credentials(auth_request, - "CRAM-MD5", credentials_callback); - return; - } + if (!parse_cram_response(request, data, data_size, &error)) { + e_info(auth_request->mech_event, "%s", error); + auth_request_fail(auth_request); + return; + } + if (!auth_request_set_username(auth_request, request->username, + &error)) { + e_info(auth_request->mech_event, "%s", error); + auth_request_fail(auth_request); + return; } - if (error == NULL) - error = "authentication failed"; - - e_info(auth_request->mech_event, "%s", error); - auth_request_fail(auth_request); + auth_request_lookup_credentials(auth_request, "CRAM-MD5", + credentials_callback); } static void -- 2.47.3