From fc52d176ce0f82397ff371cce317bf2e801053b8 Mon Sep 17 00:00:00 2001 From: Roman Bogorodskiy Date: Wed, 21 Jan 2026 19:55:54 +0100 Subject: [PATCH] bhyve: do not use deprecated IOAPIC option The '-I' flag for enabling IOAPIC was deprecated long ago in bhyve: https://cgit.freebsd.org/src/commit/?id=a1a4cbea587a6e201e07dc121268f3e559e2969f And IOAPIC is provided unconditionally since then. As no supported FreeBSD versions require that now, simply drop this flag. Signed-off-by: Roman Bogorodskiy Reviewed-by: Michal Privoznik --- src/bhyve/bhyve_command.c | 2 -- tests/bhyvexml2argvdata/x86_64/bhyvexml2argv-acpiapic.args | 1 - 2 files changed, 3 deletions(-) diff --git a/src/bhyve/bhyve_command.c b/src/bhyve/bhyve_command.c index ff079da9ef..54e9185e8a 100644 --- a/src/bhyve/bhyve_command.c +++ b/src/bhyve/bhyve_command.c @@ -951,8 +951,6 @@ virBhyveProcessBuildBhyveCmd(struct _bhyveConn *driver, virDomainDef *def, /* Options */ if (def->features[VIR_DOMAIN_FEATURE_ACPI] == VIR_TRISTATE_SWITCH_ON) virCommandAddArg(cmd, "-A"); /* Create an ACPI table */ - if (def->features[VIR_DOMAIN_FEATURE_APIC] == VIR_TRISTATE_SWITCH_ON) - virCommandAddArg(cmd, "-I"); /* Present ioapic to the guest */ if (def->features[VIR_DOMAIN_FEATURE_MSRS] == VIR_TRISTATE_SWITCH_ON) { if (def->msrs_features[VIR_DOMAIN_MSRS_UNKNOWN] == VIR_DOMAIN_MSRS_UNKNOWN_IGNORE) virCommandAddArg(cmd, "-w"); diff --git a/tests/bhyvexml2argvdata/x86_64/bhyvexml2argv-acpiapic.args b/tests/bhyvexml2argvdata/x86_64/bhyvexml2argv-acpiapic.args index 146e3c6eee..a3d521069d 100644 --- a/tests/bhyvexml2argvdata/x86_64/bhyvexml2argv-acpiapic.args +++ b/tests/bhyvexml2argvdata/x86_64/bhyvexml2argv-acpiapic.args @@ -2,7 +2,6 @@ bhyve \ -c 1 \ -m 214 \ -A \ --I \ -u \ -H \ -P \ -- 2.47.3