From fc749cd71e0ff48a5cc09571e1f036a045bb3a23 Mon Sep 17 00:00:00 2001 From: Nicolas Coden Date: Sun, 25 Mar 2018 17:39:19 +0200 Subject: [PATCH] fix: use 6-decimal precision between breakpoint 6 decimals is an arbitrary choice. Big enough to give sub-pixels renderd widths in mose use cases and small enough to not being round by browsers. --- scss/components/_visibility.scss | 4 ++-- scss/util/_breakpoint.scss | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/scss/components/_visibility.scss b/scss/components/_visibility.scss index 8906f5977..f649055cb 100644 --- a/scss/components/_visibility.scss +++ b/scss/components/_visibility.scss @@ -6,7 +6,7 @@ /// @param {Keyword} $size - Breakpoint to use. **Must be a breakpoint defined in `$breakpoints`.** @mixin show-for($size) { $size: map-get($breakpoints, $size); - $size: -zf-bp-to-em($size) - (1 / 16); + $size: -zf-bp-to-em($size) - .000001; @include breakpoint($size down) { display: none !important; @@ -20,7 +20,7 @@ $upper-bound-size: -zf-map-next($breakpoints, $size); // more often than not this will be correct, just one time round the loop it won't so set in scope here - $lower-bound: -zf-bp-to-em($lower-bound-size) - (1 / 16); + $lower-bound: -zf-bp-to-em($lower-bound-size) - .000001; // test actual lower-bound-size, if 0 set it to 0em @if strip-unit($lower-bound-size) == 0 { $lower-bound: -zf-bp-to-em($lower-bound-size); diff --git a/scss/util/_breakpoint.scss b/scss/util/_breakpoint.scss index a9f5f4a72..9865ed520 100644 --- a/scss/util/_breakpoint.scss +++ b/scss/util/_breakpoint.scss @@ -77,7 +77,7 @@ $breakpoint-classes: (small medium large) !default; // Convert any pixel, rem, or unitless value to em $bp: -zf-bp-to-em($bp); @if $bp-max { - $bp-max: -zf-bp-to-em($bp-max) - .0001; + $bp-max: -zf-bp-to-em($bp-max) - .000001; } // Conditions to skip media query creation -- 2.47.2