From fd383bf8b6954d3ce46c27a1ed55fea226369b86 Mon Sep 17 00:00:00 2001 From: Markus Elfring Date: Tue, 10 Jun 2025 14:14:09 +0200 Subject: [PATCH] RDMA/cxgb4: Delete an unnecessary check before kfree() in c4iw_rdev_open() MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit It can be known that the function “kfree” performs a null pointer check for its input parameter. It is therefore not needed to repeat such a check before its call. Thus remove a redundant pointer check. The source code was transformed by using the Coccinelle software. Signed-off-by: Markus Elfring Link: https://patch.msgid.link/cdc577a5-cebd-404a-b762-cc6fee0870dc@web.de Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/cxgb4/device.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/infiniband/hw/cxgb4/device.c b/drivers/infiniband/hw/cxgb4/device.c index 034b85c422555..b67747ae6a688 100644 --- a/drivers/infiniband/hw/cxgb4/device.c +++ b/drivers/infiniband/hw/cxgb4/device.c @@ -905,8 +905,7 @@ static int c4iw_rdev_open(struct c4iw_rdev *rdev) return 0; err_free_status_page_and_wr_log: - if (c4iw_wr_log && rdev->wr_log) - kfree(rdev->wr_log); + kfree(rdev->wr_log); free_page((unsigned long)rdev->status_page); destroy_ocqp_pool: c4iw_ocqp_pool_destroy(rdev); -- 2.47.2