From fd91ac817d681c6d7aed445978109f0b557a4fd7 Mon Sep 17 00:00:00 2001 From: Andrea Bolognani Date: Tue, 27 Jun 2017 10:28:22 +0200 Subject: [PATCH] conf: Clean up virDomainHostdevDefNew() Follow the same style as other similar functions. Signed-off-by: Andrea Bolognani --- src/conf/domain_conf.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 84da9e4d51..9276cd90bb 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -2434,13 +2434,13 @@ void virDomainVideoDefFree(virDomainVideoDefPtr def) virDomainHostdevDefPtr virDomainHostdevDefNew(virDomainXMLOptionPtr xmlopt) { - virDomainHostdevDefPtr def = NULL; + virDomainHostdevDefPtr def; - if (VIR_ALLOC(def) < 0 || - VIR_ALLOC(def->info) < 0) { - VIR_FREE(def); + if (VIR_ALLOC(def) < 0) return NULL; - } + + if (VIR_ALLOC(def->info) < 0) + goto error; if (xmlopt && xmlopt->privateData.hostdevNew && -- 2.47.2