From fe165e70cd787806fe0809efc2db45ff0451d645 Mon Sep 17 00:00:00 2001 From: Luca Boccassi Date: Mon, 29 Nov 2021 10:23:49 +0000 Subject: [PATCH] coredump: flush accumulating buffer after parsing core file --- src/coredump/stacktrace.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/coredump/stacktrace.c b/src/coredump/stacktrace.c index 24ea087d382..a74ef41ac9d 100644 --- a/src/coredump/stacktrace.c +++ b/src/coredump/stacktrace.c @@ -326,7 +326,7 @@ static int parse_core(int fd, const char *executable, char **ret, JsonVariant ** .package_metadata = &package_metadata, .modules = &modules, }; - char *buf = NULL; + _cleanup_free_ char *buf = NULL; size_t sz = 0; int r; @@ -379,6 +379,9 @@ static int parse_core(int fd, const char *executable, char **ret, JsonVariant ** goto finish; } + r = fflush_and_check(c.f); + if (r < 0) + goto finish; c.f = safe_fclose(c.f); *ret = TAKE_PTR(buf); @@ -396,8 +399,6 @@ finish: safe_fclose(c.f); - free(buf); - return r; } -- 2.47.3