From fe81bdc213a95a5e0f2253f01938350c1dd64352 Mon Sep 17 00:00:00 2001 From: Eric Leblond Date: Sun, 6 Mar 2016 21:40:18 +0100 Subject: [PATCH] detect-ssl-version: simplify code and fix memlea --- src/detect-ssl-version.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/detect-ssl-version.c b/src/detect-ssl-version.c index 599d26b877..266c15d68d 100644 --- a/src/detect-ssl-version.c +++ b/src/detect-ssl-version.c @@ -200,7 +200,7 @@ DetectSslVersionData *DetectSslVersionParse(char *str) } if (ret > 1) { - const char *str_ptr[5]; + const char *str_ptr; char *orig; uint8_t found = 0, neg = 0; char *tmp_str; @@ -212,7 +212,7 @@ DetectSslVersionData *DetectSslVersionParse(char *str) int i; for (i = 1; i < ret; i++) { - res = pcre_get_substring((char *) str, ov, MAX_SUBSTRINGS, i, &str_ptr[i]); + res = pcre_get_substring((char *) str, ov, MAX_SUBSTRINGS, i, &str_ptr); if (res < 0) { SCLogError(SC_ERR_PCRE_GET_SUBSTRING, "pcre_get_substring failed"); if (found == 0) @@ -220,7 +220,7 @@ DetectSslVersionData *DetectSslVersionParse(char *str) break; } - orig = SCStrdup((char*) str_ptr[i]); + orig = SCStrdup((char*) str_ptr); if (unlikely(orig == NULL)) { goto error; } @@ -272,6 +272,7 @@ DetectSslVersionData *DetectSslVersionParse(char *str) found = 1; neg = 0; SCFree(orig); + pcre_free_substring(str_ptr); } } -- 2.47.2