From fffafb2b5e521476bdd911ed0cc64909cfc0cf5f Mon Sep 17 00:00:00 2001 From: Filipe Brandenburger Date: Thu, 7 Jun 2018 13:07:56 -0700 Subject: [PATCH] udev: fix usage of udev_device_new_from_stat_rdev() in journalctl The refactor in #9200 inadvertently dropped the variable assignment to traverse the device and its hierarchy in add_matches_for_device(). This was uncovered by Coverity (CID #1393310). Fix that by restoring the assignment. Tested: `journalctl /dev/sda` now filters journalctl output again. --- src/journal/journalctl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/journal/journalctl.c b/src/journal/journalctl.c index 9ad1b31fa34..696abcd4505 100644 --- a/src/journal/journalctl.c +++ b/src/journal/journalctl.c @@ -207,6 +207,7 @@ static int add_matches_for_device(sd_journal *j, const char *devpath) { if (r < 0) return log_error_errno(r, "Failed to get udev device from devnum %u:%u: %m", major(st.st_rdev), minor(st.st_rdev)); + d = device; while (d) { _cleanup_free_ char *match = NULL; const char *subsys, *sysname, *devnode; -- 2.47.3