From 5ce39113eeaacd6fa9fa9677c23c8f662ca84453 Mon Sep 17 00:00:00 2001 From: Nick Porter Date: Tue, 27 Jan 2026 10:23:48 +0000 Subject: [PATCH] Pacify Coverity (CID #1680659 and #1680658) Coverity doesn't appear to look inside state_entry_create to see that it leaves the mutex unlocked on failure. --- src/lib/server/state.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/lib/server/state.c b/src/lib/server/state.c index 68f3b016244..ccdb6204107 100644 --- a/src/lib/server/state.c +++ b/src/lib/server/state.c @@ -868,6 +868,14 @@ int fr_state_store(fr_state_tree_t *state, request_t *request) if (!entry) { talloc_free(request_state_replace(request, state_ctx)); request_data_restore(request, &data); /* Put it back again */ + +#ifdef __COVERITY__ + /* + * Coverity doesn't see that state_entry_create releases + * the lock on failure + */ + PTHREAD_MUTEX_UNLOCK(&state->mutex) +#endif return -1; } -- 2.47.3