From 9d535ff3a7abeea099e9bc7920c54c087a605816 Mon Sep 17 00:00:00 2001 From: Iskren Chernev Date: Mon, 22 May 2017 14:20:26 +0300 Subject: [PATCH] Address some review comments I added moment.isImmutable and fixed unnecessary cloning. --- src/lib/units/offset.js | 4 ++-- src/moment.js | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/lib/units/offset.js b/src/lib/units/offset.js index e29f2cae4..03d3bd8e7 100644 --- a/src/lib/units/offset.js +++ b/src/lib/units/offset.js @@ -203,8 +203,8 @@ export function hasAlignedHourOffset (input) { export function isDaylightSavingTime () { return ( - this.utcOffset() > new Moment(this).month(0).utcOffset() || - this.utcOffset() > new Moment(this).month(5).utcOffset() + this.utcOffset() > this.month(0).utcOffset() || + this.utcOffset() > this.month(5).utcOffset() ); } diff --git a/src/moment.js b/src/moment.js index d810e2a6a..feb8cedd7 100644 --- a/src/moment.js +++ b/src/moment.js @@ -7,6 +7,7 @@ import { hooks as moment, setHookCallback } from './lib/utils/hooks'; moment.version = '2.18.1'; +moment.isImmutable = true; import { min, -- 2.47.2