From 6091fd45f5c8c0a1d81cde6c4b339b8333467324 Mon Sep 17 00:00:00 2001 From: drh Date: Mon, 8 Jul 2019 12:44:47 +0000 Subject: [PATCH] Comment improvements. No changes to code. FossilOrigin-Name: b0629132bc346f7a9025c0edf52114fc81385cd7a41ff1fa5d353179df276b92 --- manifest | 19 ++++++++----------- manifest.uuid | 2 +- src/alter.c | 8 ++++++-- src/resolve.c | 4 +++- 4 files changed, 18 insertions(+), 15 deletions(-) diff --git a/manifest b/manifest index cabbcab55b..a7508bed1b 100644 --- a/manifest +++ b/manifest @@ -1,5 +1,5 @@ -C Have\sALTER\sTABLE\sdetect\sand\serror\sout\sfor\sthe\scase\swhere\srenaming\sa\scolumn\schanges\sa\sthe\sinterpretation\sof\sa\sdouble-quoted\sidentifier\sin\sthe\sdatabase\sschema\sfrom\san\sSQL\sliteral\sto\sa\scolumn\sreference. -D 2019-07-02T20:10:02.773 +C Comment\simprovements.\s\sNo\schanges\sto\scode. +D 2019-07-08T12:44:47.815 F .fossil-settings/empty-dirs dbb81e8fc0401ac46a1491ab34a7f2c7c0452f2f06b54ebb845d024ca8283ef1 F .fossil-settings/ignore-glob 35175cdfcf539b2318cb04a9901442804be81cd677d8b889fcc9149c21f239ea F LICENSE.md df5091916dbb40e6e9686186587125e1b2ff51f022cc334e886c19a0e9982724 @@ -456,7 +456,7 @@ F spec.template 86a4a43b99ebb3e75e6b9a735d5fd293a24e90ca F sqlite.pc.in 42b7bf0d02e08b9e77734a47798d1a55a9e0716b F sqlite3.1 fc7ad8990fc8409983309bb80de8c811a7506786 F sqlite3.pc.in 48fed132e7cb71ab676105d2a4dc77127d8c1f3a -F src/alter.c bb45a2df945060a3125009d3d5fa7458b8fd9b123eb7128475aa3db3c688e48c +F src/alter.c 3c5b9bdfdba1ce9090fafa1d643139127a68a5355f73c59865566dfff52cf98a F src/analyze.c 58db66344a5c58dcabb57f26696f6f2993956c830446da40b444051d2fdaf644 F src/attach.c 78e986baee90cb7b83fb9eafa79c22581a8ada14030fd633b0683c95cf11213c F src/auth.c 0fac71038875693a937e506bceb492c5f136dd7b1249fbd4ae70b4e8da14f9df @@ -520,7 +520,7 @@ F src/pragma.h 4a9fabff14db4487a734dfeeb4be984ce662bfdccfae16145b9c732327735e13 F src/prepare.c 78027c6231fbb19ca186a5f5f0c0a1375d9c2cec0655273f9bd90d9ff74a34b3 F src/printf.c 9be6945837c839ba57837b4bc3af349eba630920fa5532aa518816defe42a7d4 F src/random.c 80f5d666f23feb3e6665a6ce04c7197212a88384 -F src/resolve.c 93b7bc7c45efa6322d92293361c51a873690daed50cf77eeff88a448246b0d5a +F src/resolve.c 24fab1875d5f5fbaff7b4cc783ba2ef14d842e3dffaceb3fc6b7c8cbdf29d4d7 F src/rowset.c d977b011993aaea002cab3e0bb2ce50cf346000dff94e944d547b989f4b1fe93 F src/select.c 9187f2c65744e975b191ccee49946732ee922f8bf40da998b322aca1633405ea F src/shell.c.in 82f8a473c01662f52233c6c75b9bf88d0d2cab276086d5d4ca6f2ff57a3e48eb @@ -1831,10 +1831,7 @@ F vsixtest/vsixtest.tcl 6a9a6ab600c25a91a7acc6293828957a386a8a93 F vsixtest/vsixtest.vcxproj.data 2ed517e100c66dc455b492e1a33350c1b20fbcdc F vsixtest/vsixtest.vcxproj.filters 37e51ffedcdb064aad6ff33b6148725226cd608e F vsixtest/vsixtest_TemporaryKey.pfx e5b1b036facdb453873e7084e1cae9102ccc67a0 -P eab4297577e4d325fed4757867fc77860de7448998d86f098c8a50272e17d35e -R 345332b27d681f48c6f6235823b1591a -T *branch * tkt9b78184b-alt -T *sym-tkt9b78184b-alt * -T -sym-trunk * -U dan -Z 4f5c772cb1a84553bf3caf8b00b061e5 +P 5dbb0734aff25e47a58a64abe0e96636cbf8a7a5006df0cfe10af8629af9133c +R ac9b5ba34302450931e115680b088bd7 +U drh +Z a67bbe3580af7e6b560d171c92504acc diff --git a/manifest.uuid b/manifest.uuid index ae5e68f100..3fbb3e0de2 100644 --- a/manifest.uuid +++ b/manifest.uuid @@ -1 +1 @@ -5dbb0734aff25e47a58a64abe0e96636cbf8a7a5006df0cfe10af8629af9133c \ No newline at end of file +b0629132bc346f7a9025c0edf52114fc81385cd7a41ff1fa5d353179df276b92 \ No newline at end of file diff --git a/src/alter.c b/src/alter.c index c1bdb6e1c9..0c102089ad 100644 --- a/src/alter.c +++ b/src/alter.c @@ -1271,7 +1271,9 @@ static void renameParseCleanup(Parse *pParse){ /* ** SQL function: ** -** sqlite_rename_column(zSql, iCol, bQuote, zNew, zTable, zOld) +** sqlite_rename_column(...) +** +** The function requires exactly 10 arguments: ** ** 0. zSql: SQL statement to rewrite ** 1. type: Type of object ("table", "view" etc.) @@ -1292,7 +1294,9 @@ static void renameParseCleanup(Parse *pParse){ ** ** This function is used internally by the ALTER TABLE RENAME COLUMN command. ** It is only accessible to SQL created using sqlite3NestedParse(). It is -** not reachable from ordinary SQL passed into sqlite3_prepare(). +** not reachable from ordinary SQL passed into sqlite3_prepare(). Except, +** this function is reachable for testing purposes if the +** SQLITE_TESTCTRL_INTERNAL_FUNCTIONS test-control is engaged. */ static void renameColumnFunc( sqlite3_context *context, diff --git a/src/resolve.c b/src/resolve.c index 8dac077eed..0a22e74786 100644 --- a/src/resolve.c +++ b/src/resolve.c @@ -818,7 +818,9 @@ static int resolveExprStep(Walker *pWalker, Expr *pExpr){ && sqlite3Config.bInternalFunctions==0 ){ /* Internal-use-only functions are disallowed unless the - ** SQL is being compiled using sqlite3NestedParse() */ + ** SQL is being compiled using sqlite3NestedParse(). The + ** SQLITE_TESTCTRL_INTERNAL_FUNCTIONS test-control will override + ** this restriction for testing purposes. */ no_such_func = 1; pDef = 0; } -- 2.47.2