From 217c84bcd1f1f4884e9fda044b6af9e140f8fe94 Mon Sep 17 00:00:00 2001 From: Princeton Ferro Date: Sat, 18 Jan 2020 20:03:37 +0100 Subject: [PATCH] vala: Always bail if there are semantic errors Previously introduced by 1430c461d4a45026331663989113feb195588255 --- vala/valacodecontext.vala | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/vala/valacodecontext.vala b/vala/valacodecontext.vala index 9bce9f19d..1c3ad77cd 100644 --- a/vala/valacodecontext.vala +++ b/vala/valacodecontext.vala @@ -520,7 +520,9 @@ public class Vala.CodeContext { analyzer.analyze (this); - if (!keep_going && report.get_errors () > 0) { + // Don't run the FlowAnalyzer if we have semantic errors, since + // the messages from FlowAnalyzer will usually be nonsensical. + if (report.get_errors () > 0) { return; } -- 2.47.2