From cc44cc3894d444acf06e4d3214d7ff8be43b8f18 Mon Sep 17 00:00:00 2001 From: Daniel Schuba Date: Tue, 26 Sep 2017 09:38:37 +0200 Subject: [PATCH] Requested changes. Improved naming, renamed variable and defaulted to false --- docs/pages/button.md | 4 +++- scss/components/_button.scss | 10 +++++----- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/docs/pages/button.md b/docs/pages/button.md index db058c89f..cd6f9e92f 100644 --- a/docs/pages/button.md +++ b/docs/pages/button.md @@ -59,7 +59,9 @@ Additional classes can be added to your button to change its size and shape. So Large Such Expand Wow, Small Expand -Wow, Small + Expand for Large +Wow, Expand only on small viewport +Expand on medium and smaller +Expand on medium and larger ``` --- diff --git a/scss/components/_button.scss b/scss/components/_button.scss index 970a6053f..a83554a66 100644 --- a/scss/components/_button.scss +++ b/scss/components/_button.scss @@ -82,7 +82,7 @@ $button-transition: background-color 0.25s ease-out, color 0.25s ease-out !defau /// Additional responsive classes for .expanded /// @type Boolean -$responsive-expanded-button: true !default; +$button-responsive-expanded: false !default; // TODO: Document button-base() mixin @mixin button-base { @@ -275,22 +275,22 @@ $responsive-expanded-button: true !default; &.expanded { @include button-expand; } - @if $responsive-expanded-button { + @if $button-responsive-expanded { @each $size in $breakpoint-classes { @include breakpoint(#{$size} only) { - &.expanded-for-#{$size} { + &.expanded-#{$size} { @include button-expand; } } @if $size != $-zf-zero-breakpoint { @include breakpoint(#{$size} down) { - &.expanded-for-#{$size}-down { + &.expanded-#{$size}-down { @include button-expand; } } @include breakpoint(#{$size}) { - &.expanded-for-#{$size}-up { + &.expanded-#{$size}-up { @include button-expand; } } -- 2.47.2